Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluation Context Merging 3.2.2 is missing before hooks #131

Closed
beeme1mr opened this issue Aug 11, 2022 · 2 comments · Fixed by #132
Closed

Evaluation Context Merging 3.2.2 is missing before hooks #131

beeme1mr opened this issue Aug 11, 2022 · 2 comments · Fixed by #132
Assignees
@beeme1mr
Labels
documentation Improvements or additions to documentation specification

Comments

@beeme1mr
Copy link
Member

beeme1mr commented Aug 11, 2022 •
edited
Loading

Requirement 3.2.2 should included the before hook.

API (global) -> client -> invocation -> before hooks

An explanation of why the before hook has the highest priority should be included in the non-normative section.
@beeme1mr beeme1mr added documentation Improvements or additions to documentation specification labels Aug 11, 2022
@toddbaert
Copy link
Member

toddbaert commented Aug 12, 2022 •
edited
Loading

I mentioned this in a previous PR...

I'm not sure I agree. This doesn't really have much to do with hooks - it's really about setting context at various levels. Personally, I would rather get rid of this requirement entirely then basically have the exact same information in 2 places.

@toddbaert
Copy link
Member

Maybe we could just have a link in the non-normative section of 3.2.1 to 4.3.4?

@beeme1mr beeme1mr assigned beeme1mr and unassigned toddbaert Aug 12, 2022
@beeme1mr beeme1mr linked a pull request Aug 12, 2022 that will close this issue
Consolidate evaluation context merge order in the spec #132
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beeme1mr beeme1mr

Labels
documentation Improvements or additions to documentation specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidate evaluation context merge order in the spec open-feature/spec
2 participants
@beeme1mr @toddbaert