Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs should not be translated #525

Closed
sf2ne opened this issue Aug 18, 2021 · 2 comments
Closed

Logs should not be translated #525

sf2ne opened this issue Aug 18, 2021 · 2 comments
Assignees
Labels

Comments

@sf2ne
Copy link
Collaborator

sf2ne commented Aug 18, 2021

The following translation strings all appear in logs:

  • server.start=Server online at {0}
  • changes.cleanup.scheduled=Scheduling change record cleanup every {0}message.
  • cleanup.scheduled=Scheduling Agreement Bot message and Node message cleanup every {0}

For Chinese (zh_CN, zh_TW), Japanese, Korean, Portuguese and German these messages won't display correctly in the logs.

image.png
image.png
image.png

@sf2ne
Copy link
Collaborator Author

sf2ne commented Aug 18, 2021

Update: Log files having multiple languages would pose problems for administrators so we will be hardcoding all log strings to be in English.

@sf2ne sf2ne self-assigned this Aug 18, 2021
@sf2ne sf2ne changed the title Logs do not accept Unicode Logs should not be translated Aug 18, 2021
@sf2ne
Copy link
Collaborator Author

sf2ne commented Aug 26, 2021

Verified locally

@sf2ne sf2ne closed this as completed Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant