Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Service doesn't handle deleted containers #13611

Closed
cristiancalugaru opened this issue Oct 17, 2023 · 2 comments · Fixed by #14497
Closed

Storage Service doesn't handle deleted containers #13611

cristiancalugaru opened this issue Oct 17, 2023 · 2 comments · Fixed by #14497
Assignees
Labels
enhancement New feature or request Ingestion

Comments

@cristiancalugaru
Copy link
Contributor

cristiancalugaru commented Oct 17, 2023

Affected module
Backend

Describe the bug
When deleting an S3 bucket (container) and running S3 Storage Service ingestion, the deleted container is not removed from OM.

To Reproduce
Delete an S3 bucket which was already ingested in OM, then re-ingest S3 containers in OM. The deleted S3 bucket is still present as a container in OM.

Expected behavior
OM should reflect the fact that the S3 bucket was deleted and also delete it.

Additional context
The fix most likely involves something similar with how tables are handled, in the database_service, as a post_process step:
https://github.com/open-metadata/OpenMetadata/blob/main/ingestion/src/metadata/ingestion/source/database/database_service.py#L139

@pmbrull pmbrull added enhancement New feature or request Ingestion labels Oct 17, 2023
@harshach harshach moved this to Backend - Bugs & Minor Features in Release 1.3.0 Oct 22, 2023
@harshach
Copy link
Collaborator

@cristiancalugaru will you be able to contribute this?

@cristiancalugaru
Copy link
Contributor Author

@harshach yes, please assign it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Ingestion
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants