Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column name max length is too low #7680

Closed
fredriv opened this issue Sep 23, 2022 · 2 comments · Fixed by #12092
Closed

Column name max length is too low #7680

fredriv opened this issue Sep 23, 2022 · 2 comments · Fixed by #12092

Comments

@fredriv
Copy link

fredriv commented Sep 23, 2022

Affected module
Ingestion Framework

Describe the bug
While ingesting tables from Snowflake, we got a lot of warnings saying that the column name was too long. The maximum in Open Metadata seems to be 128 characters, but Snowflake column names can be up to 255 characters long.

Example error message (long column name replaced with xyz):

[2022-09-22 11:06:52] WARNING  {Ingestion:sql_column_handler:246} - Unexpected exception processing column [{'name': 'xyz', 'type': DECIMAL(precision=38, scale=0), 'nullable': True, 'default': None, 'autoincrement': False, 'comment': None, 'primary_key': False}]: 1 validation error for Column
name -> __root__
  ensure this value has at most 128 characters (type=value_error.any_str.max_length; limit_value=128)

To Reproduce
Ingest a Snowflake table with a column name longer than 128 characters.

Expected behavior
I expect Open Metadata to be able to ingest tables with long column names.

Version:

  • OS: MacOS
  • Python version: 3.9.9
  • OpenMetadata version: 0.12
  • OpenMetadata Ingestion package version: openmetadata-ingestion[snowflake]==0.12.0.2

Additional context
Add any other context about the problem here.

@FabrizioCafolla
Copy link

+1

@charliemenke
Copy link
Contributor

+1 also an issue when yielding a Table Name

@pmbrull pmbrull moved this to 👀 In review in Release 1.1.1 Jul 11, 2023
@pmbrull pmbrull linked a pull request Jul 11, 2023 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from 👀 In review to 🔖 Ready in Release 1.1.1 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 🔖 Ready
Development

Successfully merging a pull request may close this issue.

6 participants