Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#warning is not a portable/standard preprocessor and it produces a C1021: invalid preprocessor command 'warning' error when building with MSVC. #1435

Closed
ZwwWayne opened this issue Oct 26, 2021 · 3 comments
Closed

#warning is not a portable/standard preprocessor and it produces a C1021: invalid preprocessor command 'warning' error when building with MSVC. #1435

ZwwWayne opened this issue Oct 26, 2021 · 3 comments
Assignees
@zhouzaida
Labels
Bug:P3

Comments

@ZwwWayne
Copy link
Collaborator

#warning is not a portable/standard preprocessor and it produces a C1021: invalid preprocessor command 'warning' error when building with MSVC.

Originally posted by @HolyWu in #1381 (comment)
@grimoire
Copy link
Member

I think removing the warning can fix this bug.
But it is hard to create an environment with CUDA_ARCH<=200.

@zhouzaida
Copy link
Collaborator

We can refer to pytorch/pytorch#20484 to use a portable way of the warning clause

@zhouzaida zhouzaida assigned zhouzaida and unassigned grimoire Nov 16, 2021
@zhouzaida zhouzaida mentioned this issue Nov 19, 2021
Merged
7 tasks
@ZwwWayne
Copy link
Collaborator Author

Resolved in #1510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhouzaida zhouzaida

Labels
Bug:P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grimoire @ZwwWayne @zhouzaida