Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny fix: fix preprocess_vimeo90k_dataset.py args name #281

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

hahnjiang
Copy link
Contributor

No description provided.

@innerlee
Copy link
Contributor

Hi, thanks for the contribution! Argparse should support both "a-b" and "a_b", so, does the original code caused any problems?

@hahnjiang
Copy link
Contributor Author

"a-b" will cause exception.

Traceback (most recent call last):
  File "preprocess_vimeo90k_dataset.py", line 154, in <module>
    generate_anno_file(args.train_list)
AttributeError: 'Namespace' object has no attribute 'train_list'

@innerlee
Copy link
Contributor

What was the shell cmd used?

@hahnjiang
Copy link
Contributor Author

cmd:

python preprocess_vimeo90k_dataset.py .../mmediting/data/sequences  .../mmediting/data/sequences  .../mmediting/data/sep_trainlist.txt  --make-lmdb

@innerlee
Copy link
Contributor

Thanks! I see. The replacement does not work on positional args.

@innerlee innerlee merged commit 29d6487 into open-mmlab:master Apr 28, 2021
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
@OpenMMLab-Assistant-007
Copy link

Hi!
@hahnjiang
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants