Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add TTSR Net #314

Merged
merged 5 commits into from
May 24, 2021
Merged

[Feature] Add TTSR Net #314

merged 5 commits into from
May 24, 2021

Conversation

Yshuo-Li
Copy link
Collaborator

No description provided.

@Yshuo-Li
Copy link
Collaborator Author

Based on #313

@codecov
Copy link

codecov bot commented May 17, 2021 •
edited
Loading

Codecov Report

Merging #314 (5abd4d1) into master (ee2d010) will increase coverage by 0.07%.
The diff coverage is 93.47%.

❗ Current head 5abd4d1 differs from pull request most recent head d1b3834. Consider uploading reports for the commit d1b3834 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   80.93%   81.00%   +0.07%     
==========================================
  Files         164      164              
  Lines        8228     8293      +65     
  Branches     1194     1197       +3     
==========================================
+ Hits         6659     6718      +59     
- Misses       1425     1431       +6     
  Partials      144      144
Flag Coverage Δ
unittests 81.00% <93.47%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/pipelines/random_down_sampling.py 89.13% <ø> (ø)
mmedit/models/backbones/__init__.py 100.00% <ø> (ø)
mmedit/models/backbones/sr_backbones/ttsr_net.py 96.25% <92.50%> (-3.75%) ⬇️
mmedit/datasets/pipelines/__init__.py 100.00% <100.00%> (ø)
mmedit/datasets/pipelines/augmentation.py 97.04% <100.00%> (+0.04%) ⬆️
mmedit/models/backbones/sr_backbones/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2d010...d1b3834. Read the comment docs.

innerlee
innerlee reviewed May 17, 2021
View reviewed changes
mmedit/models/backbones/sr_backbones/ttsr_net.py Outdated
upsample_kernel=3)

# stage 2
self.first2 = _conv3x3_layer(2 * texture_channels + mid_channels,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always start with "conv" if it is conv. In this case,

  • first1 -> conv1
  • first2 -> conv2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start with conv and end with conv, so named as first and last

liyinshuo added 2 commits May 18, 2021 17:19
@innerlee
Copy link
Contributor

Looks good

@innerlee innerlee merged commit f05b4fc into open-mmlab:master May 24, 2021
@Yshuo-Li Yshuo-Li deleted the tn branch May 24, 2021 11:27
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
@Yshuo-Li
[Feature] Add TTSR Net (open-mmlab#314)
aecee6f 
* [Feature] Add TTSRNet

* Rename

* Rename

* Rename

* Add license

Co-authored-by: liyinshuo <liyinshuo@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerlee innerlee innerlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yshuo-Li @innerlee