[Doc] Update description for Vimeo90K #349
Conversation
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
+ Coverage 79.98% 80.09% +0.10%
==========================================
Files 180 181 +1
Lines 9435 9496 +61
Branches 1377 1385 +8
==========================================
+ Hits 7547 7606 +59
- Misses 1698 1699 +1
- Partials 190 191 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| To prepare the annotation file for training, you need to download the official training list path for Vimeo90K from the official website, and run the following command: | ||
|
|
||
| ```shell | ||
| python tools/data/super-resolution/vimeo90k/preprocess_vimeo90k_dataset.py None None ./data/Vimeo90K/official_train_list.txt |
There was a problem hiding this comment.
The two None looks strange.
There was a problem hiding this comment.
Since gt_path and lq_path are required in prepare_vimeo90k_dataset.py, but not used if make-lmdb is False.
This is an (ugly) workaround. Another solution is to make this argument optional.
There was a problem hiding this comment.
I see. They should be optional
There was a problem hiding this comment.
Okay, I will modify it.
* Update description for Vimeo90K * Update folder structure * Make gt_path and lq_path optional
Added folder structure, and instructions to use
prepare_vimeo90k_dataset.py