Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mmcv minimum version #378

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Conversation

ckkelvinchan
Copy link
Member

Motivation

As discussed in #376, _load_checkpoint_with_prefix is used in StyleGAN, but is not included in mmcv < 1.3.

Modification

This PR changes the minimum mmcv version specified in mmedit/__init__.py, from 1.0.2 to 1.3.

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #378 (8ff559f) into master (2c21fa8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 8ff559f differs from pull request most recent head 7701c1a. Consider uploading reports for the commit 7701c1a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
+ Coverage   80.30%   80.32%   +0.02%     
==========================================
  Files         184      184              
  Lines        9831     9831              
  Branches     1427     1427              
==========================================
+ Hits         7895     7897       +2     
+ Misses       1743     1742       -1     
+ Partials      193      192       -1     
Flag Coverage Δ
unittests 80.30% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/__init__.py 73.68% <100.00%> (ø)
...ls/components/stylegan2/generator_discriminator.py 86.14% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c21fa8...7701c1a. Read the comment docs.

@innerlee innerlee merged commit 7328829 into open-mmlab:master Jun 17, 2021
@ckkelvinchan ckkelvinchan deleted the mmcv_ver branch July 8, 2021 03:12
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants