-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix bug in restoration_video_inference.py #379
Conversation
Can this be tested? |
The unittests stucked at |
Do all vid models require cuda? |
Not really, and those apis for inference are actually not included in unittests. |
Would you like to have a try? You can use a dummy model in the test (say, one layer, as long as the input/output format is good) |
Our general philosophy is to test everything 😃 |
Sure, let me think about how to write a test for it. |
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 80.44% 80.45% +0.01%
==========================================
Files 185 186 +1
Lines 9889 9911 +22
Branches 1441 1444 +3
==========================================
+ Hits 7955 7974 +19
- Misses 1742 1744 +2
- Partials 192 193 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Fix bug for sliding window inference * Add unittest for inference
Motivation
In restoration_video_inference.py, when using
a part of the input frames is omitted. This results in fewer output frames.
Modification
This PR fixes the bug and replace the original command by