Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add argument 'repeat' to SRREDSMultipleGTDataset #672

Merged
merged 4 commits into from
Jan 11, 2022

Conversation

ckkelvinchan
Copy link
Member

Motivation

As indicated in #671, training BasicVSR++ with 8 GPUs causes an error, since REDS4 contains 4 validation folders, which cannot be tested with 8 GPUs. This PR fixes the issue by repeating the validation data (e.g. from 4 folders to 8)

Modification

  1. Modify mmedit/datasets/sr_reds_multiple_gt_dataset.py
  2. Modify config of BasicVSR++

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #672 (af7b8d5) into master (9e7d78f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   80.67%   80.65%   -0.02%     
==========================================
  Files         199      199              
  Lines       11371    11375       +4     
  Branches     1818     1819       +1     
==========================================
+ Hits         9173     9175       +2     
- Misses       1915     1916       +1     
- Partials      283      284       +1     
Flag Coverage Δ
unittests 80.64% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/sr_reds_multiple_gt_dataset.py 100.00% <100.00%> (ø)
...ls/components/stylegan2/generator_discriminator.py 84.93% <0.00%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e7d78f...af7b8d5. Read the comment docs.

@ckkelvinchan ckkelvinchan merged commit 61dfdd6 into open-mmlab:master Jan 11, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants