Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Support windows path #738

Merged
merged 11 commits into from
Feb 18, 2022
Merged

[Improve] Support windows path #738

merged 11 commits into from
Feb 18, 2022

Conversation

Yshuo-Li
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #738 (5132bbd) into master (e9f4097) will increase coverage by 0.09%.
The diff coverage is 82.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
+ Coverage   82.95%   83.05%   +0.09%     
==========================================
  Files         215      216       +1     
  Lines       12121    12192      +71     
  Branches     1945     1964      +19     
==========================================
+ Hits        10055    10126      +71     
- Misses       1762     1763       +1     
+ Partials      304      303       -1     
Flag Coverage Δ
unittests 83.01% <82.14%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/apis/restoration_video_inference.py 20.33% <37.50%> (+2.48%) ⬆️
mmedit/datasets/pipelines/augmentation.py 98.49% <100.00%> (+<0.01%) ⬆️
mmedit/datasets/sr_folder_multiple_gt_dataset.py 100.00% <100.00%> (ø)
mmedit/datasets/sr_folder_video_dataset.py 98.61% <100.00%> (+0.06%) ⬆️
mmedit/datasets/sr_reds_dataset.py 100.00% <100.00%> (ø)
mmedit/datasets/sr_test_multiple_gt_dataset.py 100.00% <100.00%> (ø)
mmedit/datasets/sr_vid4_dataset.py 100.00% <100.00%> (ø)
mmedit/datasets/sr_vimeo90k_dataset.py 100.00% <100.00%> (ø)
mmedit/datasets/sr_vimeo90k_multiple_gt_dataset.py 100.00% <100.00%> (ø)
mmedit/datasets/vfi_vimeo90k_dataset.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9f4097...5132bbd. Read the comment docs.

@wangruohui
Copy link
Member

We can merge the master branch now.

@wangruohui wangruohui merged commit 8740805 into open-mmlab:master Feb 18, 2022
@Yshuo-Li Yshuo-Li deleted the win branch April 7, 2022 07:41
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* [Improve] Support windows path

* [Improve] Support windows path

* separate windows workflow

* fix bug of '/'

* fix bug of '/' in Windows

* fix bug of '/' in Windows

* install 'av' in CI

* Update build-windows.yml

* re.split

* cu102

Co-authored-by: wangruohui <12756472+wangruohui@users.noreply.github.com>
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* [Improve] Support windows path

* [Improve] Support windows path

* separate windows workflow

* fix bug of '/'

* fix bug of '/' in Windows

* fix bug of '/' in Windows

* install 'av' in CI

* Update build-windows.yml

* re.split

* cu102

Co-authored-by: wangruohui <12756472+wangruohui@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants