-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] flip_ratio
in RandomAffine
pipeline is inverted
#799
Conversation
original: `flip_ratio=1.` means always no flip and `flip_ratio=0.` means always flip after: `flip_ratio=1.` means always flip and `flip_ratio=0.` means always no flip
Because Is it correct? |
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
==========================================
+ Coverage 83.05% 83.08% +0.02%
==========================================
Files 216 216
Lines 12192 12253 +61
Branches 1964 1978 +14
==========================================
+ Hits 10126 10180 +54
- Misses 1763 1764 +1
- Partials 303 309 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Yes, it is. |
It seems there is another error. When flipping, the center is shifted. @wdmwhh, if the modification works, please let me know and I will clean the code and merge this PR. |
flip_ratio
in RandomAffine
pipeline is inverted
Yes, it makes sense. Thanks for your kindness. |
…#799) * fix flip_ratio bug original: `flip_ratio=1.` means always no flip and `flip_ratio=0.` means always flip after: `flip_ratio=1.` means always flip and `flip_ratio=0.` means always no flip * add some notes to modification * modify center, add unittests * clean test codes * clean test codes Co-authored-by: wangruohui <12756472+wangruohui@users.noreply.github.com>
…#799) * fix flip_ratio bug original: `flip_ratio=1.` means always no flip and `flip_ratio=0.` means always flip after: `flip_ratio=1.` means always flip and `flip_ratio=0.` means always no flip * add some notes to modification * modify center, add unittests * clean test codes * clean test codes Co-authored-by: wangruohui <12756472+wangruohui@users.noreply.github.com>
original:
flip_ratio=1.
means always no flip andflip_ratio=0.
means always flipafter:
flip_ratio=1.
means always flip andflip_ratio=0.
means always no flip