Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OrientedRepPoints #127

Closed
3 tasks
zytx121 opened this issue Mar 12, 2022 · 6 comments · Fixed by #286
Closed
3 tasks

Support OrientedRepPoints #127

zytx121 opened this issue Mar 12, 2022 · 6 comments · Fixed by #286
Assignees
Labels
algorithm Dev-RD Development Requirements Doc Medium

Comments

@zytx121
Copy link
Collaborator

zytx121 commented Mar 12, 2022

This issue describes the development requirement of a feature we wish to collaborate with the community.
In this issue, we welcome the community developers to participate in the development of Oriented RepPoints.

Description

Support OrientedRepPoints. You can use points_in_polygons op in mmcv to judge whether points are inside polygons.

Steps

  • Add OrientedRepPointsHead and SpatialBorderLoss in MMRotate
  • Benchmark the performance
  • Prepare and release the models

Resources

@zytx121 zytx121 assigned zytx121 and unassigned zytx121 Mar 12, 2022
@zytx121 zytx121 added the Dev-RD Development Requirements Doc label Mar 14, 2022
@zytx121 zytx121 changed the title [Community Task] Support OrientedRepPoints Support OrientedRepPoints Mar 14, 2022
@LiWentomng
Copy link
Contributor

Hello, I'm preparing the codes of Oriented RepPoints for MMRotate.
The chamfer distance 2d used in Oriented RepPoints needs cuda compile. I bulid a new ops folder like old version, then compile it in the environment of MMRotate successfully. But the error of error in nnd updateOutput: invalid device function appears during the training.
Can you help me to make chamfer distance 2d op avaliable in the mmcv like points_in_polygons.

The resources of chamfer distance 2d are here:

@yangxue0827
Copy link
Collaborator

@zytx121

@zytx121
Copy link
Collaborator Author

zytx121 commented Apr 30, 2022

Thanks for your PR, and we will add this Cuda op ASAP.

@zytx121
Copy link
Collaborator Author

zytx121 commented May 4, 2022

Chamfer Distance has been PR in mmcv open-mmlab/mmcv#1933

@xxmomo
Copy link

xxmomo commented Jun 2, 2022

When I validate the model on DOTA,I can't figure out the range of mAP . Is it from 0-1 or 0-100? Thanks for your replay!

@yangxue0827 yangxue0827 linked a pull request Jun 6, 2022 that will close this issue
@yangxue0827
Copy link
Collaborator

@LiWentomng chamfer distance is merged in mmcv now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Dev-RD Development Requirements Doc Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants