Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array of stringified infos #32

Closed
ompiteam opened this issue Sep 12, 2014 · 8 comments
Closed

array of stringified infos #32

ompiteam opened this issue Sep 12, 2014 · 8 comments
Assignees
Labels
Milestone

Comments

@ompiteam
Copy link
Contributor

As discussed a while ago, I think we should add something like this to the end of the hwloc_obj structure:

char infos; /< \brief Array of string name=value /
unsigned infos_count; /
*< \brief Length of the infos array */

We would store in there things like:

DMIBoardVendor=Tyan (currently in obj->attr->machine.dmi_board_vendor)
DMIBoardModel=S4885 (currently in obj->attr->machine.dmi_board_info)
PCIVendor=AMD
PCIModel=Radeon HD4350

Some of them are already used in obj->name but that doesn't need to change.

Some system-fields might be interesting too, they should go in the topology or in the widest related object:

Backend=Synthetic
OS=Linux
LinuxCpuset=/foobar
FsRoot=/var/lib/topology/myworderfulmachine
Hostname=foobar

@ompiteam ompiteam added this to the v1.1 milestone Sep 12, 2014
@ompiteam
Copy link
Contributor Author

Imported from trac issue 31. Created by bgoglin on 2010-02-23T02:43:25, last modified: 2012-12-22T03:18:28

@ompiteam
Copy link
Contributor Author

Trac comment by bgoglin on 2010-05-22 17:36:27:

(In [2132]) Add an array of string infos in objects.

Print them in hwloc_obj_attr_snprintf.

Export them as a new element in XML files.

Refs #31.

@ompiteam ompiteam added the bug label Sep 12, 2014
@ompiteam
Copy link
Contributor Author

Trac comment by bgoglin on 2010-05-22 17:37:18:

(In [2133]) Store DMI infos in object infos.

Refs #31.

@ompiteam
Copy link
Contributor Author

Trac comment by bgoglin on 2010-05-22 17:40:47:

Distinguish between object-specific and topology-wide infos.

@ompiteam
Copy link
Contributor Author

Trac comment by sthibaul on 2010-06-22 06:16:42:

Maybe it would be easier to store it as an array of structures containing the name and the property separately, instead of having to parse the '=' sign all the time.

Also, I guess it'd be good to provide a helper to look for some information, so the application programmer can just e.g. vendor = hwloc_object_get_info(object, "DMIBoardVendor").

@ompiteam
Copy link
Contributor Author

Trac comment by bgoglin on 2010-06-26 07:18:18:

Done. And indeed, it's better now.

@ompiteam
Copy link
Contributor Author

Trac comment by bgoglin on 2010-09-16 09:57:49:

Fixed in trunk [2320] when merging the objinfos branch (and applied to the libpci branch as well in [2323]).

@ompiteam
Copy link
Contributor Author

Trac comment by bgoglin on 2011-03-29 13:36:23:

Milestone v1.1 deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants