Merge pull request #2425 from rhc54/topic/cov

rhc54 · web-flow · commit 0afdd41215da · 2021-12-16T07:48:48.000-08:00
Silence Coverity warnings
diff --git a/src/client/pmix_client_spawn.c b/src/client/pmix_client_spawn.c
@@ -440,15 +440,15 @@ static void wait_cbfunc(struct pmix_peer_t *pr, pmix_ptl_hdr_t *hdr, pmix_buffer
             nptr = NULL;
             PMIX_LIST_FOREACH (ns, &pmix_globals.nspaces, pmix_namespace_t)
             {
-                if (0 == strcmp(ns->nspace, n2)) {
+                if (PMIX_CHECK_NSPACE(ns->nspace, nspace)) {
                     nptr = ns;
                     break;
                 }
             }
             if (NULL == nptr) {
                 /* shouldn't happen, but protect us */
                 nptr = PMIX_NEW(pmix_namespace_t);
-                nptr->nspace = strdup(n2);
+                nptr->nspace = strdup(nspace);
                 pmix_list_append(&pmix_globals.nspaces, &nptr->super);
             }
             /* as a client, we only handle a select set of the flags */

Original file line number	Diff line number	Diff line change
`@@ -440,15 +440,15 @@ static void wait_cbfunc(struct pmix_peer_t pr, pmix_ptl_hdr_t hdr, pmix_buffer`
`440`	`440`	`nptr = NULL;`
`441`	`441`	`PMIX_LIST_FOREACH (ns, &pmix_globals.nspaces, pmix_namespace_t)`
`442`	`442`	`{`
`443`		`- if (0 == strcmp(ns->nspace, n2)) {`
	`443`	`+ if (PMIX_CHECK_NSPACE(ns->nspace, nspace)) {`
`444`	`444`	`nptr = ns;`
`445`	`445`	`break;`
`446`	`446`	`}`
`447`	`447`	`}`
`448`	`448`	`if (NULL == nptr) {`
`449`	`449`	`/* shouldn't happen, but protect us */`
`450`	`450`	`nptr = PMIX_NEW(pmix_namespace_t);`
`451`		`- nptr->nspace = strdup(n2);`
	`451`	`+ nptr->nspace = strdup(nspace);`
`452`	`452`	`pmix_list_append(&pmix_globals.nspaces, &nptr->super);`
`453`	`453`	`}`
`454`	`454`	`/* as a client, we only handle a select set of the flags */`