Skip to content

Commit 6287d43

Browse files
author
Ralph Castain
committed
If someone specifically asks for knem support and we can't do it, then we really should abort.
1 parent f92ccaf commit 6287d43

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

config/opal_check_knem.m4

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,15 @@
2222
AC_DEFUN([OPAL_CHECK_KNEM],[
2323
OPAL_VAR_SCOPE_PUSH([opal_check_knem_happy opal_check_knem_$1_save_CPPFLAGS opal_check_knem_dir])
2424
AC_ARG_WITH([knem],
25-
[AC_HELP_STRING([--with-knem(=DIR)],
26-
[Build knem Linux kernel module support, searching for headers in DIR])])
25+
[AC_HELP_STRING([--with-knem(=DIR)],
26+
[Build knem Linux kernel module support, searching for headers in DIR ])],
27+
[], [with_knem=no])
2728

2829
OPAL_CHECK_WITHDIR([knem], [$with_knem], [include/knem_io.h])
2930
opal_check_knem_$1_save_CPPFLAGS="$CPPFLAGS"
3031

3132
AS_IF([test "$with_knem" != "no"],
32-
[AS_IF([test ! -z "$with_knem" -a "$with_knem" != "yes"],
33+
[AS_IF([test "$with_knem" != "yes"],
3334
[opal_check_knem_dir="$with_knem"])
3435

3536
_OPAL_CHECK_PACKAGE_HEADER([$1],
@@ -60,7 +61,7 @@ AC_DEFUN([OPAL_CHECK_KNEM],[
6061

6162
AS_IF([test "$opal_check_knem_happy" = "yes" -a "$opal_cv_knem_version_ok" = "yes"],
6263
[$2],
63-
[AS_IF([test ! -z "$with_knem" -a "$with_knem" != "no"],
64+
[AS_IF([test "$with_knem" != "no"],
6465
[AC_MSG_ERROR([KNEM support requested but not found. Aborting])])
6566
$3])
6667
OPAL_VAR_SCOPE_POP

0 commit comments

Comments
 (0)