Skip to content

Commit 8396bef

Browse files
Joe-DownsJoseph Downs
authored andcommitted
WIP: avoid double inclusion of abi.h
1 parent 39c20b7 commit 8396bef

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

ompi/mpi/bindings/c_header.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -215,11 +215,6 @@ def output_constant(const, use_enum: bool, mangle_name: bool):
215215
output.append(f"{binding[0]} P{' '.join(binding[1:])};\n")
216216

217217
# ================================ Final Output ================================
218-
output.append("""#ifndef _ABI_INTERNAL_
219-
#define _ABI_INTERNAL_
220-
#include "stddef.h"
221-
#include "stdint.h"
222-
""")
223218
output.append("#endif /* _ABI_INTERNAL_ */")
224219

225220
for i, line in enumerate(output):

ompi/mpi/c/abi.h.in

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,22 @@
66
* $HEADER$
77
*/
88

9+
#ifndef _ABI_INTERNAL_
10+
#define _ABI_INTERNAL_
11+
12+
/* TODO: figure out which includes we need, change to <> instead of "" */
913
#include "stddef.h"
1014
#include "stdint.h"
1115

12-
//#include <stdint.h>
16+
/* #include <stdint.h> */
1317

1418
#define MPI_VERSION 5
1519
#define MPI_SUBVERSION 0
1620

1721
#define MPI_ABI_VERSION 1
1822
#define MPI_ABI_SUBVERSION 0
1923

24+
/* TODO: add comment why this is hardcoded to avoid extra generation logic */
2025
typedef struct MPI_ABI_Comm * MPI_Comm;
2126
typedef struct MPI_ABI_Datatype * MPI_Datatype;
2227
typedef struct MPI_ABI_Errhandler * MPI_Errhandler;

0 commit comments

Comments
 (0)