-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoded show_help text causing compiler warnings #13167
Comments
Do you know when those limits were raised, and to what size? The tools are going to soar past that limit for their "usage" topic. |
No. I was just going to split up the strings to be argv-style lists, each of which are <4095 bytes. The rendered results will be the same, but we'll be able to handle older compilers. |
FWIW: I fixed this in my version of your script - you can see it here: openpmix/openpmix#3577 It was a pretty simple fix. I also printed out the array in a more human-readable fashion for my convenience. |
Also note that I've had a lot of trouble getting thru the old CI based on Josh's docker images due to Python conflicts. Those old images do have Python 3 in them, but apparently before they supported all those cute formatting directives. So I've had to remove a bunch of them, replacing them with string concatenations. Might be a warning about compatibility with older Python 3 releases. |
I'll take a look at it and see what I can steal. My show-help is more complicated because of the hierarchical support (i.e., you can ask "--help foo" to get help on an option). I also added a bunch of checking in it to ensure we were using all the topics, weren't missing topics, the executables have all their options in their "--help" output, etc. Figured if I'm going to spend a month pulling it all into memory, I might as well make sure it is all correct too! This way, it becomes a CI tool to double-check someone committing a new option or a new tool. |
With older GCC (e.g., 8), we get warnings when compiling the new very-long strings from #13144:
The text was updated successfully, but these errors were encountered: