-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-introduce make generate
into CI
#112
Comments
Here is the diff that I made by manually updating the generated conversion files:
|
kubernetes/kubernetes#101567 has been unassigned; it looks like progress isn't currently being made for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When updating
conversion-gen
tov0.20.2
in #111, I found a bug. Certain conversion functions were not being included in the generated output.This bug is being tracked (kubernetes/kubernetes#101567) and is already triaged and assigned.
To get around this bug, I manually changed the conversion file. This will meet our needs in the short term, but is not sustainable. Once the fix is available to us, we should upgrade our
conversion-gen
and get our automation working correctly again.The text was updated successfully, but these errors were encountered: