Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconsider ConstraintTemplate status placement #367

Open
acpana opened this issue Oct 23, 2023 · 0 comments
Open

reconsider ConstraintTemplate status placement #367

acpana opened this issue Oct 23, 2023 · 0 comments

Comments

@acpana
Copy link
Contributor

acpana commented Oct 23, 2023

It seems that the ConstraintTemplatePodStatus could be better homed in Gatekeeper:

// CreateCRDError represents a single error caught during parsing, compiling, etc.
type CreateCRDError struct {
Code string `json:"code"`
Message string `json:"message"`
Location string `json:"location,omitempty"`
}
// ByPodStatus defines the observed state of ConstraintTemplate as seen by
// an individual controller.
type ByPodStatus struct {
// a unique identifier for the pod that wrote the status
ID string `json:"id,omitempty"`
ObservedGeneration int64 `json:"observedGeneration,omitempty"`
Errors []CreateCRDError `json:"errors,omitempty"`
}
// ConstraintTemplateStatus defines the observed state of ConstraintTemplate.
type ConstraintTemplateStatus struct {
Created bool `json:"created,omitempty"`
ByPod []ByPodStatus `json:"byPod,omitempty"`
// INSERT ADDITIONAL STATUS FIELD - define observed state of cluster
// Important: Run "make" to regenerate code after modifying this file
}

If that's possible we should consider making that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant