Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document requires sync data annotation #261

Closed
sozercan opened this issue Nov 22, 2022 · 7 comments
Closed

document requires sync data annotation #261

sozercan opened this issue Nov 22, 2022 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@sozercan
Copy link
Member

#251

looks like we are missing docs on this

@sozercan sozercan added the documentation Improvements or additions to documentation label Nov 22, 2022
@stale
Copy link

stale bot commented Jan 31, 2023

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 31, 2023
@julianKatz
Copy link
Contributor

Please add docs!

@apeabody
Copy link
Contributor

Saving a few notes here:

Overall format is [ [{}OR{}] AND [{}OR{}] ]

Example:

   metadata.gatekeeper.sh/requiresSyncData: |
      "[
        [
          {
            "groups":["extensions"],
            "versions": ["v1beta1"],
            "kinds": ["Ingress"]
          },
          {
            "group": ["networking.k8s.io"],
            "version": ["v1beta1", "v1"],
            "kind": ["Ingress"]
          }
        ],
        [
          {
            "groups":["storage.k8s.io"],
            "versions": ["v1"],
            "kinds": ["StorageClass"]
          }
        ]
      ]"

expands to

    metadata.gatekeeper.sh/requiresSyncData: |
      "[
        [
          {
            "groups":["extensions"],
            "versions": ["v1beta1"],
            "kinds": ["Ingress"]
          },
          {
            "group": ["networking.k8s.io"],
            "version": ["v1beta1"],
            "kind": ["Ingress"]
          }
          {
            "group": ["networking.k8s.io"],
            "version": ["v1"],
            "kind": ["Ingress"]
          }
        ],
        [
          {
            "groups":["storage.k8s.io"],
            "versions": ["v1"],
            "kinds": ["StorageClass"]
          }
        ]
      ]"

Summarizing as this template requires Gvk:

  • extensions / v1beta1 / Ingress OR networking.k8s.io / v1beta1 / Ingress OR networking.k8s.io / v1 / Ingress
    AND
  • storage.k8s.io / v1 / StorageClass

@stale
Copy link

stale bot commented Apr 12, 2023

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 12, 2023
@sozercan sozercan removed the stale label Apr 12, 2023
@apeabody
Copy link
Contributor

Hi @sozercan - I can take this issue, if someone can assign it as I don't have access.

@stale
Copy link

stale bot commented Jun 11, 2023

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 11, 2023
@apeabody apeabody removed the stale label Jun 12, 2023
@stale
Copy link

stale bot commented Aug 11, 2023

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 11, 2023
@stale stale bot closed this as completed Sep 3, 2023
@apeabody apeabody removed the stale label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants