Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s versions used for e2e #1075

Closed
ritazh opened this issue Jan 20, 2021 · 1 comment · Fixed by #1268
Closed

K8s versions used for e2e #1075

ritazh opened this issue Jan 20, 2021 · 1 comment · Fixed by #1268

Comments

@ritazh
Copy link
Member

ritazh commented Jan 20, 2021

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Currently we default to K8s v1.19.0 for the e2es.

KUBERNETES_VERSION ?= v1.19.0

When a change is introduced that needs to be validated across older K8s versions (for back compat) and newer K8s versions, we need to build confidence that the change introduced continues to work in older K8s versions and new versions. e.g. removal of selfLink in K8s v1.20

Few things to consider:

  • Do we run a matrix of all supported K8s versions or do we always use the latest?
  • If we do want to run the tests against a matrix, which versions do we use? (e.g. currently supported K8s versions: 1.18, 1.19, 1.20)
  • If we do want to run the tests against a matrix, do we do this as a PR gate or only against master or a job we can trigger?

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Gatekeeper version:
  • Kubernetes version: (use kubectl version):
@maxsmythe
Copy link
Contributor

Is there anything preventing us from running 5 of these jobs in parallel? Running these tests against multiple cluster versions could be essentially free, with the main cost being that flakiness will hurt twice as much.

How many dimensions would be in the matrix? FWIW I don't think we need to be testing manifest + helm for all K8s versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants