Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gator test's pkg/ files into their own sub-package #1779

Closed
4 tasks
julianKatz opened this issue Dec 29, 2021 · 4 comments
Closed
4 tasks

Refactor gator test's pkg/ files into their own sub-package #1779

julianKatz opened this issue Dec 29, 2021 · 4 comments
Labels

Comments

@julianKatz
Copy link
Contributor

Currently, the pkg/gator package holds all the code for gator test. With the addition of the gator test command, this structure will no longer make sense.

As part of this issue, complete the following:

  • Create a pkg/gator/test package that holds the most test specific functionality.
  • Update cmd/gator/test to use the new package
  • Move the ToTemplate function (or something like it) into a shared util.go at pkg/gator
  • Update pkg/gator/validate to use that new package
@julianKatz julianKatz added the enhancement New feature or request label Dec 29, 2021
@julianKatz julianKatz self-assigned this Dec 29, 2021
@julianKatz julianKatz removed their assignment Jan 11, 2022
@willbeason willbeason added this to the gator beta milestone May 31, 2022
@stale
Copy link

stale bot commented Aug 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 1, 2022
@julianKatz
Copy link
Contributor Author

Still a good idea

@stale stale bot removed the stale label Aug 2, 2022
@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 1, 2022
@ritazh ritazh added triaged and removed stale labels Oct 3, 2022
@sozercan sozercan removed this from the gator beta milestone Dec 7, 2022
@davis-haba
Copy link
Contributor

I think we can close this once #2398 is merged. This PR included a big refactor of the Gator CLI to break up commands into their own subpackages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants