Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating infracost/setup-opa to open-policy-agent #4141

Closed
5 tasks done
srenatus opened this issue Dec 15, 2021 · 9 comments
Closed
5 tasks done

Migrating infracost/setup-opa to open-policy-agent #4141

srenatus opened this issue Dec 15, 2021 · 9 comments
Labels

Comments

@srenatus
Copy link
Contributor

srenatus commented Dec 15, 2021

@tim775 and @alikhajeh1 have created a Github Action to setup OPA that allows a simpler setup of OPA in a Github Actions Workflow. It's fixing a year-old (on the day, almost) issue we've had, this is long-awaited feature of the OPA ecosystem. @tim775 has agreed to help maintaining the action code when it's in the open-policy-agent org.

To move forward we need to:

  • Hold a vote amongst the OPA maintainers (the process is outlined in the GOVERNANCE.md file).
  • Create an setup-opa-maintainers team on GitHub and add @tim775 to the new team.
  • Transfer the infracost/setup-opa repo into the open-policy-agent organization
  • Ensure that DCO check is enabled on the repo
  • Add a security notice on the action repo pointing back to SECURITY.md

The project is currently using GHA for CI and does not have any secrets configured (other than the standard github token) so migration should be simple.

@tim775 can you mention anyone else who should be added to the maintainer team for the action?

@ritazh @maxsmythe @shomron cc-ing you to vote on this like we've done in the past for GK, conftest, etc.

@tim775
Copy link
Member

tim775 commented Dec 15, 2021

Please make @aliscott a maintainer also. Cheers.

@tsandall
Copy link
Member

+1

1 similar comment
@shomron
Copy link

shomron commented Dec 15, 2021

+1

@maxsmythe
Copy link
Contributor

This SGTM (+1 vote)

Thanks for doing this!

@ritazh
Copy link
Member

ritazh commented Dec 22, 2021

+1
Thanks for working on this! 🙇

@tsandall
Copy link
Member

tsandall commented Jan 21, 2022

@srenatus @tim775 I've created the new setup-opa-maintainers team. Once you initiate the repo transfer we can accept it and finish this off!

EDIT: Just to clarify, @tim775 you'll need to do the repo transfer (not @srenatus 😅 )

@tim775
Copy link
Member

tim775 commented Jan 21, 2022

I'm not able to transfer to open-policy-agent, I get the error You don’t have the permission to create public repositories on open-policy-agent

I think it may be better for you to create a fork in open-policy-agent. The action is already being used in a few actions and I'm not sure if transferring will cause those to break. If you create the fork I will update infracost/setup-opa README directing people to open-policy-agent, then archive it.

EDIT: @tsandall the repo is transferred. References to infracost/setup-opa are being redirected.

@anderseknert
Copy link
Member

That's awesome @tim775 ! Yeah, we'd like be the first to break should the redirect not work ;)

- name: Download OPA
uses: infracost/setup-opa@v1

Thank you for this 😃

@srenatus
Copy link
Contributor Author

This is done, thanks everyone! 🥳 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants