Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the footer background color from gray to blue #5254

Closed
UtkarshMishra12 opened this issue Oct 15, 2022 · 12 comments
Closed

Changing the footer background color from gray to blue #5254

UtkarshMishra12 opened this issue Oct 15, 2022 · 12 comments

Comments

@UtkarshMishra12
Copy link
Contributor

What is the underlying problem you're trying to solve?

Changing the footer background color from gray to blue

Describe the ideal solution

As I was scrolling on the website when I see the footer it was having a gray color which looks odd compared to other colors present on the website.

So I just wanted to convert it into a blue color which will improve the look of the website.

I'm attaching the screenshot below.

Before :
Screenshot (491)

Describe a "Good Enough" solution

Additional Context

@UtkarshMishra12
Copy link
Contributor Author

Image Link

You can see the updated footer.

@anderseknert
Copy link
Member

Hmm, obviously this is subjective, but I'm not sure I agree with this. The footer is gray like the OPA logo, and many of the other elements already use that blue color. Can't say I feel strongly about this though :)

@UtkarshMishra12
Copy link
Contributor Author

So what's the conclusion? The blue color will definitely improve the UX.

@anderseknert
Copy link
Member

anderseknert commented Oct 15, 2022

There’s no conclusion, and others are free to weigh in with their opinion. That a blue footer “definitely” would improve the UX is also just an opinion, but if others agree, we should have it changed.

@UtkarshMishra12
Copy link
Contributor Author

Let me know about the thoughts of other maintainers & contributors. So that we can decide.

@Parsifal-M
Copy link
Contributor

Just my two cents, I think the grey is fine, and I think making it blue might clash with the gradient coloring at the top of the page. Again as @anderseknert this is subjective 😅 and I'm no UX expert...

@peteroneilljr
Copy link
Member

Hard to know without the specific color hexcode, there are many shades of blue. :)

Can you provide the hexcode for the blue you're referring to? Or better yet, can you change the color with DevTools and take a screenshot so that we can see the side-by-side comparison?

@UtkarshMishra12
Copy link
Contributor Author

@peteroneilljr Here is the image.
Screenshot (490) (1)

@anderseknert
Copy link
Member

@peteroneilljr WDYT? I have no strong opinion here.

@peteroneilljr
Copy link
Member

I like it, I don't see any reason not to do it.

@UtkarshMishra12
Copy link
Contributor Author

@peteroneilljr So may I proceed with it?

@peteroneilljr
Copy link
Member

Yes! Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants