Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OQS_SHA*_sha***_ API does not support arbitrary length updates #1606

Closed
ashman-p opened this issue Nov 7, 2023 · 4 comments
Closed

OQS_SHA*_sha***_ API does not support arbitrary length updates #1606

ashman-p opened this issue Nov 7, 2023 · 4 comments

Comments

@ashman-p
Copy link
Contributor

ashman-p commented Nov 7, 2023

For example
OQS_SHA2_sha256_inc_blocks(OQS_SHA2_sha256_ctx *state, const uint8_t *in, size_t inblocks)
This makes an assumption that all the data is present at the time of processing and thus can be broken up into blocks. This also does not easily allow parse and update processing of arbitrary fields.

The proposal would be to add a new API to support this.

OQS_SHA*_sha***_inc(OQS_SHA2_sha***_ctx *state, const uint8_t *in, size_t in_len)

@ashman-p ashman-p changed the title OQS_SHA2_sha***_ API does not support arbitrary length updates OQS_SHA*_sha***_ API does not support arbitrary length updates Nov 7, 2023
@ashman-p
Copy link
Contributor Author

ashman-p commented Nov 7, 2023

This change could be added to "Make low-level crypto algorithms implementation switchable #1599"

@dstebila dstebila added this to the 0.10.0 milestone Dec 7, 2023
@baentsch
Copy link
Member

baentsch commented Mar 7, 2024

@dstebila : What was the reason to add this issue to the 0.10.0 milestone? OK to postpone this to 0.11.0 such as to bring the 0.10.0 milestone to completion/"RC-readiness"?

@SWilson4
Copy link
Member

SWilson4 commented Mar 7, 2024

@dstebila : What was the reason to add this issue to the 0.10.0 milestone? OK to postpone this to 0.11.0 such as to bring the 0.10.0 milestone to completion/"RC-readiness"?

This was needed to implement LMS. Since that work is slated for a later release, I think it's safe to do the same here.

@SWilson4 SWilson4 removed this from the 0.10.0 milestone Mar 7, 2024
@ajbozarth ajbozarth moved this to Todo in liboqs planning Jul 23, 2024
@SWilson4
Copy link
Member

Completed (for SHA256) in #1650.

@github-project-automation github-project-automation bot moved this from Todo to Done in liboqs planning Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants