Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review IDs #126

Closed
baentsch opened this issue Mar 22, 2023 · 4 comments
Closed

Review IDs #126

baentsch opened this issue Mar 22, 2023 · 4 comments

Comments

@baentsch
Copy link
Member

baentsch commented Mar 22, 2023

In preparation for the IETF hackathon (and the next release), this issue is to check all algorithm IDs are in line with recent liboqs code updates:

Anything else? @bhess @xvzcf @dstebila : Did we really only update these two algorithms (breaking KATs/requiring TLS ID changes) since the last Hackathon in November 2022? (period of interest since last interop test added)

@bhess
Copy link
Member

bhess commented Mar 22, 2023

Anything else? @bhess @xvzcf @dstebila : Did we really only update these two algorithms (breaking KATs/requiring TLS ID changes)?

Wasn't there a SPHINCS+ update changing the PRF from SHA256 to SHA512?

@baentsch
Copy link
Member Author

baentsch commented Mar 22, 2023

Wasn't there a SPHINCS+ update changing the PRF from SHA256 to SHA512?

Can you point to a PR? When glancing over last year's PRs, there's nothing with the label "sphincs" standing out...

Also, KATs seem rather unchanged since a long time:

grafik

@bhess
Copy link
Member

bhess commented Mar 22, 2023

Ah ok, the PR with the change isn't merged yet: open-quantum-safe/liboqs#1420

@baentsch
Copy link
Member Author

Closing the issue given we have now tagged an ietf116 version and everyone had a chance to speak up :) Thanks, @bhess for the sanity check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants