Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: open-quantum-safe/rust team has crates.io push access #8

Closed
1 task done
thomwiggers opened this issue Mar 22, 2024 · 5 comments
Closed
1 task done

FYI: open-quantum-safe/rust team has crates.io push access #8

thomwiggers opened this issue Mar 22, 2024 · 5 comments

Comments

@thomwiggers
Copy link
Contributor

thomwiggers commented Mar 22, 2024

I see that there is some new bot set up to provision access control and maintainer status through the configuration file that is owned by this repository. Please note that:

  1. the open-quantum-safe/rust team (which I am guessing is not part of this new system) has permissions to push to crates.io,
    • its membership should probably also get managed by the TSC / this new system in some way,
  2. removing the open-quantum-safe/rust team would result in ownership of https://crates.io/crates/oqs getting lost (except that it is still registered to my account directly).

One way to work around 2. would be to set up a release process in which CI creates the releases, but that requires some engineering effort.

(unfortunately, Crates.io does not implement trusted publishers like pypi does, which would allow assigning the release permissions directly to the repository itself, so some user will need to own the release API keys).

@baentsch
Copy link
Member

Thanks for the heads-up, @thomwiggers !

@bhess bhess mentioned this issue Mar 22, 2024
@thomwiggers
Copy link
Contributor Author

thomwiggers commented Mar 22, 2024

Oh I see that the Rust team is already managed:

tsc/config.yaml

Lines 12 to 14 in fcc7133

- name: rust
maintainers:
- thomwiggers
(I had missed the teams at the top of the file).

So that means that point 1 is already addressed.

@ryjones
Copy link
Contributor

ryjones commented Mar 27, 2024

@thomwiggers I can work with you on setting up crates publishing.

@baentsch
Copy link
Member

baentsch commented Jul 1, 2024

@ryjones @thomwiggers can this issue be closed by now?

@thomwiggers
Copy link
Contributor Author

Yeah it seems that these things are actually covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants