Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing required label for properties of type object #379

Open
antoine-mulet opened this issue Oct 5, 2020 · 2 comments
Open

Missing required label for properties of type object #379

antoine-mulet opened this issue Oct 5, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@antoine-mulet
Copy link

Hi,

I have noticed that for properties of type object the "required" label is not displayed when the property is part of the list of required properties while it works fine for simple types like string for example.

image

Is there a reason for that?

Thanks,
Antoine

@shanejonas
Copy link
Member

Hi @antoine-mulet,

sorry for the late reply, that functionality is handled here: https://github.com/xops/json-schema-to-react-tree

there is a definitely need for some better support for these cases.

@antoine-mulet
Copy link
Author

Hi @shanejonas,

Thanks for the info. Should I close this issue and raise it in https://github.com/xops/json-schema-to-react-tree instead then?

@shanejonas shanejonas added the bug Something isn't working label Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants