Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

params can be content descriptors and should allow deprecated field #188

Closed
shanejonas opened this issue Mar 15, 2020 · 2 comments · Fixed by #197
Closed

params can be content descriptors and should allow deprecated field #188

shanejonas opened this issue Mar 15, 2020 · 2 comments · Fixed by #197
Labels
bug Something isn't working released

Comments

@shanejonas
Copy link
Member

iiuc, Methods can have ContentDescriptors as Params. Params can have a deprecated field. The playground currently tells me this is an error: Property deprecated is not allowed.

image

rel open-rpc/playground#372
@shanejonas shanejonas added the bug Something isn't working label Mar 15, 2020
@meowsbits
Copy link
Contributor

ℹ️ migrated from open-rpc/playground#372

meowsbits added a commit to meowsbits/meta-schema that referenced this issue Mar 26, 2020
@meowsbits
add deprecated field to contentDescriptorObject
37d62d1 
Fixes open-rpc#188
@meowsbits meowsbits mentioned this issue Mar 26, 2020
Merged
meowsbits added a commit to meowsbits/meta-schema that referenced this issue Mar 26, 2020
@meowsbits
fix(contentDescriptorObject): add deprecated property
e61bc86 
Fixes open-rpc#188
openrpc-bastion added a commit that referenced this issue Mar 26, 2020
@openrpc-bastion
chore(release): 1.7.2 [skip ci]
a404ec1 
## [1.7.2](1.7.1...1.7.2) (2020-03-26)

### Bug Fixes

* **contentDescriptorObject:** add deprecated property ([e61bc86](e61bc86)), closes [#188](#188)
* **contentDescriptorObject:** json typo ([03d6646](03d6646))
* **methodObject:** add 'externalDocs' to properties ([69765f6](69765f6)), closes [#187](#187)
* **methodObject:** add servers property ([c457f90](c457f90)), closes [#186](#186)
* **root:** add externalDocs ([d04ed72](d04ed72)), closes [#194](#194)
* **whitespace:**               whitespace(fix) ([068d862](068d862))
@openrpc-bastion
Copy link
Member

🎉 This issue has been resolved in version 1.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

meowsbits pushed a commit to meowsbits/meta-schema that referenced this issue Mar 26, 2020
@BelfordZ
Merge pull request open-rpc#188 from open-rpc/dependabot/npm_and_yarn…
4ccc43d 
…/lodash-4.17.15

chore(deps): [security] bump lodash from 4.17.11 to 4.17.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(contentDescriptorObject): add deprecated property meowsbits/meta-schema
3 participants
@shanejonas @meowsbits @openrpc-bastion