Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: close update dialog disables mouse event on page body #985

Closed
2 tasks done
OgDev-01 opened this issue Mar 9, 2023 · 5 comments · Fixed by #999
Closed
2 tasks done

Bug: close update dialog disables mouse event on page body #985

OgDev-01 opened this issue Mar 9, 2023 · 5 comments · Fixed by #999

Comments

@OgDev-01
Copy link
Contributor

OgDev-01 commented Mar 9, 2023

Describe the bug

Screen.Recording.2023-03-09.at.17.35.11.mov

Steps to reproduce

  1. Connect account
  2. Go to user profile page
  3. Click on more icon
  4. select Edit
  5. click on the X close icon

Affected services

insights.opensauced.pizza

Platforms

No response

Browsers

No response

Environment

Production, Development

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@takanome-dev
Copy link
Contributor

This issue is caused by theKashey/react-remove-scroll-bar#35 (comment)

The thing that I don't understand though is why the contributor highlight card is inside a radix dialog component and alert-dialog?
I'm having a lot of hydration issues and radix errors because DialogTrigger and AlertDialogTrigger are used outside of Dialog/AlertDialog wrapper 🤔

I'm going to open a pr to fix the issues with dialogs not closing when clicking outside ✌️

@nightknighto
Copy link
Contributor

nightknighto commented Mar 15, 2023

The bug was fixed in #987 .

@takanome-dev
Copy link
Contributor

The bug was fixed in #987

Yeah, but the dialogs won't close when clicking outside

@nightknighto
Copy link
Contributor

The bug was fixed in #987

Yeah, but the dialogs won't close when clicking outside

Good idea but unrelated to this specific issue. Should open new issues for such ideas next time 😅.

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.37.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants