Add cpi_inflatable field for each parameter in the four JSON parameters files #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1838 +/- ##
======================================
Coverage 100% 100%
======================================
Files 37 37
Lines 3100 3103 +3
======================================
+ Hits 3100 3103 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains an enhancement that makes it easier for TaxBrain to determine which parameters can have their
cpi_inflatedvalue changed in a reform.Trying to set
cpi_inflatedto true for a variable that hascpi_inflatableequal to false, will generate a reform implementation error that is raised as a ValueError, in exactly the same as if an unknown parameter name was included in the JSON reform file. This should never arise when the TaxBrain GUI is being used because TaxBrain will never prepare a JSON reform file that generates this reform error. However, just as there is no way to prevent a TaxBrain user from uploading a JSON reform file that contains an unknown parameter name, the file upload logic in TaxBrain needs to catch these kind of ValueError messages. I believe TaxBrain file upload logic already does this, so this enhancement should not involve any changes to the file upload capability.There are no changes in tax calculating logic or results.