Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semconv schema: don't require attributes on metrics #405

Open
lmolkova opened this issue Mar 27, 2024 · 0 comments
Open

Semconv schema: don't require attributes on metrics #405

lmolkova opened this issue Mar 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@lmolkova
Copy link
Contributor

Json schema validation shows error when metrics is defined without attributes
image

with Missing property "attributes".yaml-schema: https://raw.githubusercontent.com/open-telemetry/build-tools/v0.24.0/semantic-conventions/semconv.schema.json

Metrics don't have to have attributes or may inherit them through extension mechanism.
@lmolkova lmolkova added the bug Something isn't working label Mar 27, 2024
@jsuereth jsuereth closed this as completed Oct 9, 2024
@jsuereth jsuereth reopened this Oct 9, 2024
@lmolkova lmolkova transferred this issue from open-telemetry/build-tools Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Semantic Conventions Tooling
Status: Improve YAML Schema
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsuereth @lmolkova