Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SemConv MD generator should not prepend "Conditional" to requirement conditions #7

Closed
arminru opened this issue Sep 10, 2020 · 0 comments · Fixed by #24
Closed

SemConv MD generator should not prepend "Conditional" to requirement conditions #7

arminru opened this issue Sep 10, 2020 · 0 comments · Fixed by #24
Labels
semconv Related to the semantic convention generator.

Comments

@arminru
Copy link
Member

arminru commented Sep 10, 2020

From open-telemetry/opentelemetry-specification#925 (comment):

"Required: Conditional No, but recommended" looks odd and might be misleading.
The MD generator should only print the condition itself without prepending the word Conditional in the table, unless it references a footnote.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semconv Related to the semantic convention generator.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better markdown generation thisthat/build-tools
2 participants
@Oberon00 @arminru