Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Repository maintenance on opentelemetry-go* and opentelemetry-collector* #1926

Closed
pellared opened this issue Feb 6, 2024 · 12 comments
Assignees
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org

Comments

@pellared
Copy link
Member

pellared commented Feb 6, 2024

Affected Repository

https://github.com/open-telemetry/opentelemetry-go
https://github.com/open-telemetry/opentelemetry-go-contrib
https://github.com/open-telemetry/opentelemetry-go-instrumentation
https://github.com/open-telemetry/opentelemetry-go-build-tools
https://github.com/open-telemetry/opentelemetry-proto-go
https://github.com/open-telemetry/opentelemetry-collector-contrib
https://github.com/open-telemetry/opentelemetry-collector

Requested changes

Note

I think it may be more pragmatic to generate an organization-wide token in https://app.codecov.io/account/gh/open-telemetry/org-upload-token and add organization-wide GitHub secrets for GitHub Actions and Dependabot.

Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-go/settings/secrets/actions and https://github.com/open-telemetry/opentelemetry-go/settings/secrets/dependabot with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-go/settings.

Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-go-contrib/settings/secrets/actions and https://github.com/open-telemetry/opentelemetry-go-contrib/settings/secrets/dependabot with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/settings.

Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-go-instrumentation/settings/secrets/actions and https://github.com/open-telemetry/opentelemetry-go-instrumentation/settings/secrets/dependabot with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-go-instrumentation/settings.

Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-go-build-tools/settings/secrets/actions and https://github.com/open-telemetry/opentelemetry-go-build-tools/settings/secrets/dependabot with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-go-build-tools/settings.

Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-proto-go/settings/secrets/actions and https://github.com/open-telemetry/opentelemetry-proto-go/settings/secrets/dependabot with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-proto-go/settings.

Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-collector/settings/secrets/actions and https://github.com/open-telemetry/opentelemetry-collector/settings/secrets/dependabot with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-collector/settings.

Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-collector-contrib/settings/secrets/actions and https://github.com/open-telemetry/opentelemetry-collector-contrib/settings/secrets/dependabot with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-collector-contrib/settings.

Purpose

There is a new release v4 of https://github.com/codecov/codecov-action
Take notice (from release notes):

Tokenless uploading is unsupported. However, PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token). This doc shows instructions on how to add the Codecov token.

Slack thread: https://cloud-native.slack.com/archives/C01NJ7V1KRC/p1706772233505499

Expected Duration

Permanently

Repository Maintainers

@open-telemetry/go-maintainers
@open-telemetry/collector-maintainers

@pellared pellared changed the title REQUEST: Repository maintenance on opentelemetry-go REQUEST: Repository maintenance on opentelemetry-go* Feb 6, 2024
@pellared
Copy link
Member Author

pellared commented Feb 6, 2024

@MrAlias Done

@codeboten
Copy link
Contributor

I can open a separate issue, but the same will be needed for the collector repositories 😬

@pellared pellared changed the title REQUEST: Repository maintenance on opentelemetry-go* REQUEST: Repository maintenance on opentelemetry-go* and opentelemetry-collector* Feb 7, 2024
@pellared
Copy link
Member Author

pellared commented Feb 7, 2024

@codeboten Updated

@pellared
Copy link
Member Author

I learned that for dependabot the secrets needs to be additionally added to "Dependabot secrets".

I think it may be more pragmatic to generate an organization-wide token in https://app.codecov.io/account/gh/open-telemetry/org-upload-token and add organization-wide GitHub secrets for GitHub Actions and Dependabot.

@MrAlias
Copy link
Contributor

MrAlias commented Feb 23, 2024

ping @open-telemetry/technical-committee

@jack-berg
Copy link
Member

@open-telemetry/technical-committee - WDYT about this suggestion:

I think it may be more pragmatic to generate an organization-wide token in https://app.codecov.io/account/gh/open-telemetry/org-upload-token and add organization-wide GitHub secrets for GitHub Actions and Dependabot.

I think its a good idea. Can go ahead an add the secret if folks agree.

@arminru
Copy link
Member

arminru commented Mar 4, 2024

@pellared @MrAlias @codeboten

I added an org-wide CODECOV_TOKEN secret. For now, I've enabled it to be accessible to all repos also beyond Go since I assume more SIGs will run into the same issue when upgrading their Codecov action.

Please let me know if it works as expected.

cc @jack-berg

@MrAlias
Copy link
Contributor

MrAlias commented Mar 4, 2024

Thank you @arminru. That looks to have unblocked us 🎉

@pellared
Copy link
Member Author

@arminru CODECOV_TOKEN is missing as Dependabot organization-wide secret.

Because of this we cannot merge any of the following PRs created by Dependabot: https://github.com/open-telemetry/opentelemetry-go-build-tools/pulls/app%2Fdependabot

@pellared pellared reopened this Mar 14, 2024
@arminru
Copy link
Member

arminru commented Mar 14, 2024

@pellared I added the same token also as a Dependabot org secret and triggered coverage builds for your open PRs again, now they're all passing.

@pellared
Copy link
Member Author

@arminru Thanks. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org
Projects
None yet
Development

No branches or pull requests

5 participants