Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New teams docs-ja-approvers and docs-ja-maintainers #2138

Closed
2 tasks done
Tracked by #4592
svrnm opened this issue Jun 5, 2024 · 8 comments
Closed
2 tasks done
Tracked by #4592

New teams docs-ja-approvers and docs-ja-maintainers #2138

svrnm opened this issue Jun 5, 2024 · 8 comments
Assignees
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org

Comments

@svrnm
Copy link
Member

svrnm commented Jun 5, 2024

Affected Repository

https://github.com/open-telemetry/opentelemetry.io
https://github.com/open-telemetry/docs-ja

Requested changes

This request is similar to #2107

Purpose

We now have our second translation at https://opentelemetry.io/ja 🎉

@ymotongpoo, @katzchang are our first approver in this group. Eventually we also want to add @shirou but they need to become member of the Org first. We will work on that separately.

We will also work on checking what to do with https://github.com/open-telemetry/docs-ja, so please also make the newly formed group maintainers/admins for that repository.

Expected Duration

permanently

Repository Maintainers

@open-telemetry/docs-maintainers

@svrnm svrnm added the area/repo-maintenance Maintenance of repos in the open-telemetry org label Jun 5, 2024
@ymotongpoo
Copy link

Thank you @svrnm for the update and logistics!

@chalin
Copy link
Contributor

chalin commented Jun 5, 2024

Thanks @svrnm.

Hmm, I'd suggest we keep things DRY: that is, keeping the membership exclusive. Concretely:

  • docs-ja-maintainers: empty for now
  • docs-ja-approvers: with @ymotongpoo, and docs-ja-maintainers as subgroup

The zh groups should be similarly adjusted.

We then use CODEOWNERS to achieve the effect of what was originally requested, as was done via open-telemetry/opentelemetry.io#4584.

@svrnm et @open-telemetry/docs-maintainers WDYT?

@svrnm
Copy link
Member Author

svrnm commented Jun 5, 2024

@chalin having the docs-maintainers in those groups allows us to add people without raising a community issue everytime, we can remove ourselves eventually when things have evolved.

@chalin
Copy link
Contributor

chalin commented Jun 5, 2024

Thanks for providing a rational. Ok, then instead we should add @open-telemetry/docs-maintainers as a subgroup of docs-ja-maintainers.

@arminru
Copy link
Member

arminru commented Jun 17, 2024

@chalin Unfortunately that's not possible because each team can only one parent and @open-telemetry/docs-maintainers is already a child of @open-telemetry/docs-approvers as per https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md#collaborators-and-teams.

@arminru arminru self-assigned this Jun 17, 2024
@arminru
Copy link
Member

arminru commented Jun 17, 2024

Created @open-telemetry/docs-ja-maintainers (with Maintain permissions on https://github.com/open-telemetry/docs-ja) and @open-telemetry/docs-ja-approvers (with Write permissions on https://github.com/open-telemetry/docs-ja) as per https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md#collaborators-and-teams.

@arminru
Copy link
Member

arminru commented Jun 17, 2024

@shirou once you're a member of the https://github.com/open-telemetry org, any @open-telemetry/docs-ja-maintainers can invite you to @open-telemetry/docs-ja-approvers.

@arminru arminru closed this as completed Jun 17, 2024
@svrnm
Copy link
Member Author

svrnm commented Jun 17, 2024

Thanks @arminru

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org
Projects
None yet
Development

No branches or pull requests

4 participants