-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New teams docs-ja-approvers
and docs-ja-maintainers
#2138
Comments
Thank you @svrnm for the update and logistics! |
Thanks @svrnm.
Hmm, I'd suggest we keep things DRY: that is, keeping the membership exclusive. Concretely:
The We then use CODEOWNERS to achieve the effect of what was originally requested, as was done via open-telemetry/opentelemetry.io#4584. @svrnm et @open-telemetry/docs-maintainers WDYT? |
@chalin having the docs-maintainers in those groups allows us to add people without raising a community issue everytime, we can remove ourselves eventually when things have evolved. |
Thanks for providing a rational. Ok, then instead we should add @open-telemetry/docs-maintainers as a subgroup of |
@chalin Unfortunately that's not possible because each team can only one parent and @open-telemetry/docs-maintainers is already a child of @open-telemetry/docs-approvers as per https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md#collaborators-and-teams. |
Created @open-telemetry/docs-ja-maintainers (with Maintain permissions on https://github.com/open-telemetry/docs-ja) and @open-telemetry/docs-ja-approvers (with Write permissions on https://github.com/open-telemetry/docs-ja) as per https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md#collaborators-and-teams. |
@shirou once you're a member of the https://github.com/open-telemetry org, any @open-telemetry/docs-ja-maintainers can invite you to @open-telemetry/docs-ja-approvers. |
Thanks @arminru |
Affected Repository
https://github.com/open-telemetry/opentelemetry.io
https://github.com/open-telemetry/docs-ja
Requested changes
docs-ja-approvers
with @ymotongpoo, @katzchang as member, and @cartermp, @austinlparker, @chalin and @svrnm as members (all as "maintainers" for the group)docs-ja-approvers
nameddocs-ja-maintainers
with @cartermp, @austinlparker, @chalin and @svrnm as members (all as "maintainers" for the group)This request is similar to #2107
Purpose
We now have our second translation at https://opentelemetry.io/ja 🎉
@ymotongpoo, @katzchang are our first approver in this group. Eventually we also want to add @shirou but they need to become member of the Org first. We will work on that separately.
We will also work on checking what to do with https://github.com/open-telemetry/docs-ja, so please also make the newly formed group maintainers/admins for that repository.
Expected Duration
permanently
Repository Maintainers
@open-telemetry/docs-maintainers
The text was updated successfully, but these errors were encountered: