Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTel .NET Contrib - Hangfire.Core license dependency verification #2585

Open
Kielek opened this issue Feb 20, 2025 · 3 comments
Open

OTel .NET Contrib - Hangfire.Core license dependency verification #2585

Kielek opened this issue Feb 20, 2025 · 3 comments
Labels
area/legal triage:accepted This issue has been accepted and will be worked.

Comments

@Kielek
Copy link
Contributor

Kielek commented Feb 20, 2025

OpenTelemetry .NET contrib repository is hosting source code for OpenTelemetry.Instrumentation.Hangfire nuget package.

One of the dependency is Hangfire.Core licensed by double license LGPL v3 License or Commercial License.

The important part is that, if the end-user references OpenTelemetry.Instrumentation.Hangfire it automatically brings packages licensed by LGPL/Commercial. This dependency seems to be mandatory to make the instrumentation working correctly.

What is the recommendation in such cases? Can we host/maintains such library? If it is not possible, what is the recommendation for the already published artifacts.

Detected by the FOSSA scans created by #2574

@trask
Copy link
Member

trask commented Feb 20, 2025

hi @Kielek! in Java, the instrumentation libraries use a "compileOnly" dependency on the instrumented libraries, which avoids this:

if the end-user references OpenTelemetry.Instrumentation.Hangfire it automatically brings packages licensed by LGPL/Commercial

and seems reasonable from a usability perspective since users will only use the instrumentation library if they are already using the instrumented library

in addition to helping us avoid licensing issues, it also helps us avoid CVE issues (since we're not transitively passing those dependencies on to our consumers)

would something like this make sense in .Net?

@Kielek
Copy link
Contributor Author

Kielek commented Feb 21, 2025

@trask, it will be unusual. I can rise this on .NET SIG. Before we can consider, we should verify what is perspective of CNCF on similar, non-production dependency. See #2558.

@trask
Copy link
Member

trask commented Mar 11, 2025

Blocked on #2558

@trask trask added the triage:accepted This issue has been accepted and will be worked. label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/legal triage:accepted This issue has been accepted and will be worked.
Projects
Status: No status
Development

No branches or pull requests

3 participants