Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TelemetryConnectionSettings should support all config options of the exporter #177

Open
srikanthccv opened this issue Dec 31, 2023 · 1 comment

Comments

@srikanthccv
Copy link
Member

It's not possible to set protocol, compression, timeout, etc.. options with the TelemetryConnectionSettings

// The TelemetryConnectionSettings message is a collection of fields which comprise an
// offer from the Server to the Agent to use the specified settings for a network
// connection to report own telemetry.
// Status: [Beta]
message TelemetryConnectionSettings {
// The value MUST be a full URL an OTLP/HTTP/Protobuf receiver with path. Schema
// SHOULD begin with "https://", for example "https://example.com:4318/v1/metrics"
// The Agent MAY refuse to send the telemetry if the URL begins with "http://".
string destination_endpoint = 1;
// Optional headers to use when connecting. Typically used to set access tokens or
// other authorization headers. For HTTP-based protocols the Agent should
// set these in the request headers.
// For example:
// key="Authorization", Value="Basic YWxhZGRpbjpvcGVuc2VzYW1l".
Headers headers = 2;
// The Agent should use the offered certificate to connect to the destination
// from now on. If the Agent is able to validate and connect using the offered
// certificate the Agent SHOULD forget any previous client certificates
// for this connection.
// This field is optional: if omitted the client SHOULD NOT use a client-side certificate.
// This field can be used to perform a client certificate revocation/rotation.
TLSCertificate certificate = 3;
}

This leaves an ambiguity to the agent on whether to use the OTLP gRPC exporter or HTTP exporter to report its own telemetry. The TelemetryConnectionSettings should be extended to support all exporter config options.

@tigrannajaryan
Copy link
Member

This leaves an ambiguity to the agent on whether to use the OTLP gRPC exporter or HTTP exporter to report its own telemetry.

The spec requires OTLP/HTTP: https://github.com/open-telemetry/opamp-spec/blob/main/specification.md#own-telemetry-reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants