Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make emitting custom events simple #573

Open
breedx-splk opened this issue Sep 4, 2024 · 4 comments
Open

Make emitting custom events simple #573

breedx-splk opened this issue Sep 4, 2024 · 4 comments
Assignees

Comments

@breedx-splk
Copy link
Contributor

Application developers using this library want a simple and straightforward means of generating custom events. Right now, it's only possible to create custom events by jumping through a series of incantation steps, something like:

SdkEventLoggerProvider.create(rum.openTelemetry.logsBridge)
  .get(scopeName)
  .builder(eventName)
  .put(bodyField1, value1)
  ...
  .emit()

I'd like to see events become a first-class API on the OpenTelemetryRum interface, something more like:

rum.emitEvent(eventName)

which would be shorthand for something like

rum.emitEvent(name = eventName, body = body, attributes = attributes)
@RichardChukwu
Copy link

Hello @breedx-splk are you still working on this?

@breedx-splk
Copy link
Contributor Author

Hi @RichardChukwu, I'm not. There is a lot of activity in the Logging SIG right now around the event api, and it definitely seems like the existing event API in the java core repo will change....which is fine, because the API talked about in THIS issue will sit in front of whatever the core implementation ends up looking like. In other words, this will abstract it away even more for users.

Would you like to work on this?

@RichardChukwu
Copy link

I'd like to give it a try yeah. I'm an outreachy applicant and first time contributor to this repo @breedx-splk

@breedx-splk
Copy link
Contributor Author

I'd like to give it a try yeah. I'm an outreachy applicant and first time contributor to this repo @breedx-splk

Ok, thanks for the transparency and for offering to help! I'll go ahead and assign this to you to work on. Please review the CONTRIBUTING.md guidance and ensure that you're doing your best to submit well-tested, clean code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants