[AWS Xray]Change the type of content_length #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2539 +/- ##
=======================================
Coverage 91.20% 91.20%
=======================================
Files 417 417
Lines 20935 20942 +7
=======================================
+ Hits 19093 19100 +7
Misses 1379 1379
Partials 463 463
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
anuraaga
approved these changes
Mar 4, 2021
bogdandrutu
approved these changes
Mar 5, 2021
This was referenced Mar 15, 2021
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
* Change the type of attributes content_length * Re-run integration test * Add unit-test
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
otlpexporter endpoint configuration allows for an `http` or `https` scheme. The scheme is stripped off when instantiating the gRPC channel. A scheme of `https` indicates a secure channel. This aligns the collector with this hopefully soon-to-be-merged specification PR open-telemetry/opentelemetry-specification#1729 **Link to tracking Issue:** #2539 **Documentation:** Updated readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There is a bug for aws xray nodejs sdk, it emits a string type for
content_length.This pr will make xray receiver to be able to deal with both the string and number type of
content_lengthby changing the data type from*inttointerface{}Link to tracking Issue:
aws/aws-xray-sdk-node#385
Testing:
Unit test and end2end test.
Changes:
1, Changed the data type of
content_length.2, Added logic to deal with different types.
3, Added a test file to test the string type of
content_length.4, Changed the test cases of xray receiver and xray exporter relative files.