Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard way to convert from time.Time to proto Timestamp #2548

Merged

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #2548 (ae60d0b) into main (f36771a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2548      +/-   ##
==========================================
- Coverage   91.19%   91.18%   -0.01%     
==========================================
  Files         419      419              
  Lines       20983    20983              
==========================================
- Hits        19135    19133       -2     
- Misses       1381     1382       +1     
- Partials      467      468       +1     
Flag Coverage Δ
integration 69.22% <ø> (ø)
unit 90.06% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nermetricsreceiver/awsecscontainermetrics/utils.go 100.00% <100.00%> (ø)
receiver/k8sclusterreceiver/watcher.go 95.29% <0.00%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f36771a...ae60d0b. Read the comment docs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 040c856 into open-telemetry:main Mar 5, 2021
@bogdandrutu bogdandrutu deleted the fixmetricsutiltimestamp branch March 5, 2021 02:28
This was referenced Mar 15, 2021
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants