Signalfx exporter: fix calculation of network.total metric #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asuresh4
approved these changes
Mar 4, 2021
Codecov Report
@@ Coverage Diff @@
## main #2551 +/- ##
==========================================
- Coverage 91.19% 91.18% -0.01%
==========================================
Files 419 419
Lines 20983 20983
==========================================
- Hits 19135 19134 -1
- Misses 1381 1382 +1
Partials 467 467
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dmitryax
force-pushed
the
sfxexporter-fix-network-total-metric
branch
2 times, most recently
from
7b48d4a
to
2b2b3dd
Compare
memory.total was calculated based on "interface" dimension which is not ready at that point and created from "device" in the next step. It causes several duplicates of memory.total not aggregated by device/interface. This commits fixes the problem
dmitryax
force-pushed
the
sfxexporter-fix-network-total-metric
branch
from
2b2b3dd
to
d2d4bfc
Compare
bogdandrutu
approved these changes
Mar 4, 2021
This was referenced Mar 15, 2021
kisieland
referenced
this pull request
in kisieland/opentelemetry-collector-contrib
Mar 16, 2021
Updates open-telemetry/opentelemetry-collector#2482 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
memory.total was calculated based on "interface" dimension which is not ready at that point and created from "device" in the next step. It causes several duplicates of memory.total not aggregated by device/interface. This commits fixes the problem
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memory.total was calculated based on "interface" dimension which is not ready at that point and created from "device" in the next step. It causes several duplicates of memory.total not aggregated by device/interface.
This PR fixes the problem