exporter/signalfx: Correctly convert dimensions on metadata updates #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2552 +/- ##
==========================================
+ Coverage 91.32% 91.34% +0.02%
==========================================
Files 429 429
Lines 21456 21457 +1
==========================================
+ Hits 19594 19600 +6
+ Misses 1394 1392 -2
+ Partials 468 465 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asuresh4
force-pushed
the
sfxexporter-fix
branch
from
ad46e69
to
8d37b0a
Compare
jrcamp
approved these changes
Mar 4, 2021
| @@ -116,7 +108,7 @@ func getPropertiesAndTags(kmu metadata.MetadataUpdate) (map[string]*string, map[ | |||
| func (dc *DimensionClient) PushMetadata(metadata []*metadata.MetadataUpdate) error { | |||
| var errs []error | |||
| for _, m := range metadata { | |||
| dimensionUpdate := getDimensionUpdateFromMetadata(*m, dc.metricTranslator) | |||
| dimensionUpdate := getDimensionUpdateFromMetadata(*m, dc.metricsConverter) | |||
There was a problem hiding this comment.
Is this really not tested with a mock client or backend?
There was a problem hiding this comment.
It is, there are tests in exporter_test but codev does not account for tests outside the package
asuresh4
force-pushed
the
sfxexporter-fix
branch
2 times, most recently
from
e8ea51c
to
8dd99ff
Compare
|
Please rebase |
asuresh4
force-pushed
the
sfxexporter-fix
branch
from
8dd99ff
to
9235619
Compare
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
kisieland
referenced
this pull request
in kisieland/opentelemetry-collector-contrib
Mar 16, 2021
…entions (#2552) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Correctly convert dimension values while making metadata updates. Currently, the exporter invokes
sanitizeDataPointDimensionson all translated datapoints which cleans up non-alphanumeric dimension keys. This is not being done for dimensions in metadata updates. This PR ensures that dimensions are correctly translated and sanitized even in metadata updates.Testing: Added tests.