Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run tests related to the component if possible #27807

Open
atoulme opened this issue Oct 17, 2023 · 6 comments
Open

Only run tests related to the component if possible #27807

atoulme opened this issue Oct 17, 2023 · 6 comments
Labels
ci-cd CI, CD, testing, build issues help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed

Comments

@atoulme
Copy link
Contributor

atoulme commented Oct 17, 2023

Component(s)

No response

Describe the issue you're reporting

The current approach to CI is monolithic and consists in running tests for all receivers, exporters, processors and so on even though most changes are going to apply to a specific component.

I propose that we organize CI to reduce the jobs running based on patterns of change, unless a label "Run all tests" is set. This would only apply to unit tests and leave integration tests, load tests and so forth untouched.

@atoulme atoulme added the needs triage New item requiring triage label Oct 17, 2023
@TylerHelmuth
Copy link
Member

This would be great. It would need to be intelligent enough to run any tests for dependent components. If we change something in pkg or internal anything using those dependencies should have their tests run.

@TylerHelmuth TylerHelmuth added the ci-cd CI, CD, testing, build issues label Oct 17, 2023
@crobert-1 crobert-1 removed the needs triage New item requiring triage label Oct 17, 2023
@Aneurysm9
Copy link
Member

IIRC we tried this once before and got hung up on dependency resolution, though I can't seem to find the related issues/PRs. I believe that pre-dated crosslink, though, and with that tool we should be able to identify modules that depend on a module with changes and ensure that tests in those modules are also run.

While I think it would be good to reduce the scope of PR test runs in this manner, we do need to ensure we're still running the full test suite on merge and probably on a subset of PRs.

@TylerHelmuth
Copy link
Member

Definitely on any merge to main and any release prep PR

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Dec 18, 2023
@TylerHelmuth TylerHelmuth added help wanted Extra attention is needed and removed Stale labels Dec 18, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Apr 22, 2024
@TylerHelmuth TylerHelmuth added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Development

No branches or pull requests

4 participants