Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/loki] Do not promote log level to loki label #28612

Closed
mar4uk opened this issue Oct 25, 2023 · 7 comments
Closed

[exporter/loki] Do not promote log level to loki label #28612

mar4uk opened this issue Oct 25, 2023 · 7 comments
Labels
enhancement New feature or request exporter/loki Loki Exporter never stale Issues marked with this label will be never staled and automatically removed

Comments

@mar4uk
Copy link
Contributor

mar4uk commented Oct 25, 2023

Component(s)

exporter/loki

Is your feature request related to a problem? Please describe.

Currently, if the log record has a severityNumber attribute, lokiexporter adds level label corresponding to the severityNumber: see the mapping here

For example, if the log record has the attribute severityNumber=plog.SeverityNumberDebug4 label level=DEBUG4 would be added in Loki

It is not a good practice to promote log level to the label in Loki.

Describe the solution you'd like

level shouldn't be promoted to loki label automatically

Describe alternatives you've considered

No response

Additional context

No response

@mar4uk mar4uk added enhancement New feature or request needs triage New item requiring triage labels Oct 25, 2023
@crobert-1 crobert-1 added the exporter/loki Loki Exporter label Oct 26, 2023
@github-actions
Copy link
Contributor

Pinging code owners for exporter/loki: @gramidt @gouthamve @jpkrohling @mar4uk. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Removing needs triage as this was filed by a code owner and it makes sense from links provided.

Thanks for including relevant links, very clear and easy to understand!

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Oct 26, 2023
Copy link
Contributor

github-actions bot commented Jan 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 1, 2024
@crobert-1 crobert-1 removed the Stale label Jan 2, 2024
@mar4uk
Copy link
Contributor Author

mar4uk commented Feb 20, 2024

I'm a little bit delaying on this one to make sure we aligned with native loki otlp enpoint

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 22, 2024
@crobert-1 crobert-1 removed the Stale label Apr 22, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 24, 2024
@crobert-1 crobert-1 added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Jun 27, 2024
@mar4uk
Copy link
Contributor Author

mar4uk commented Sep 4, 2024

Since the loki exporter is going to be deprecated soon in favor of otlp exporter (Loki now supports otlp), I don't think we should make new changes to the loki exporter.

Will close this issue

@mar4uk mar4uk closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter/loki Loki Exporter never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Development

No branches or pull requests

2 participants