-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8sclusterreceiver] Add hierarchical-resource-quota #29555
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@dmitryax @TylerHelmuth @povilasv Can you assign me to implement this feature? |
Thank you very much. The custom controller for HierachilalResourceQuota does not use client-go and there is no Informer. I thought about using dynamicinformer, and I'll create new factory to wrap dynamicinformer.DynamicSharedInformerFactory. type dynamicSharedInformerFactory struct {
dynamicinformer.DynamicSharedInformerFactory
}
func (df *dynamicSharedInformerFactory) Start(channel <-chan struct{}) {
df.DynamicSharedInformerFactory.Start(channel)
}
var gvr = schema.GroupVersionResource{Group: "hnc.x-k8s.io", Version: "v1alpha2", Resource: "HierarchicalResourceQuota"}
func (df *dynamicSharedInformerFactory) WaitForCacheSync(channel <-chan struct{}) map[reflect.Type]bool {
cache := df.DynamicSharedInformerFactory.WaitForCacheSync(channel)
return map[reflect.Type]bool{
reflect.TypeOf(&v1alpha2.HierarchicalResourceQuota{}): cache[gvr],
}
} Do you have better implementation ideas? |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
receiver/k8scluster
Is your feature request related to a problem? Please describe.
We use hierarchical-namespaces and hierarchical-resource-quota.
https://github.com/kubernetes-sigs/hierarchical-namespaces
I'd like to obtain the information of HierarchicalResourceQuota to observe the aggregated resource limit amount for each parent namespace.
spec: https://github.com/kubernetes-sigs/hierarchical-namespaces/blob/master/api/v1alpha2/hierarchicalresourcequota_types.go#L59-L67
Describe the solution you'd like
While it is possible to perform a similar operation by retrieving and aggregating all the values of ResourceQuota when querying the values collected by k8sreceiver, it would be appreciated if the k8sclusterreceiver could handle HierarchicalResourceQuota in the same way as ResourceQuota, considering the need to be aware of parent-child relationships in the namespace.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: