-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Redisreceiver/update redis client version #29600
Merged
dmitryax
merged 2 commits into
open-telemetry:main
from
hughesjj:redisreceiver/update_redis_client_version
Dec 4, 2023
Merged
[chore] Redisreceiver/update redis client version #29600
dmitryax
merged 2 commits into
open-telemetry:main
from
hughesjj:redisreceiver/update_redis_client_version
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughesjj
changed the title
Redisreceiver/update redis client version
[chore] Redisreceiver/update redis client version
Dec 1, 2023
1 task
dmitryax
reviewed
Dec 1, 2023
dmitryax
reviewed
Dec 1, 2023
dmitryax
approved these changes
Dec 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PLease rebase
component: redisreceiver | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Upgrade the redis library dependency to resolve security vulns in v7 (also, we should be tracking v8 anyway) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
note: Upgrade the redis library dependency to resolve security vulns in v7 (also, we should be tracking v8 anyway) | |
note: Upgrade the redis library dependency to resolve security vulns in v7 |
@hughesjj there is still a conflict. Please rebase on the latest main |
repo name gomod updates update main go.sum change invocation to include background context also add for cmd/otelcontribcol add chglog go mod tidy configschema for redis retidy main Update .chloggen/redisreceiver_update_redis_client_version.yaml Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> Update .chloggen/redisreceiver_update_redis_client_version.yaml Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> Update .chloggen/redisreceiver_update_redis_client_version.yaml Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> fix chglog message
hughesjj
force-pushed
the
redisreceiver/update_redis_client_version
branch
from
December 4, 2023 19:42
76e0cd0
to
bd8c441
Compare
dmitryax
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/configschema
configschema command
cmd/otelcontribcol
otelcontribcol command
receiver/redis
Redis related issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
Testing:
Documentation: