metricsgenerationprocessor skips a rule if the second operand is 0

[flyfire2002]

Component(s)

processor/metricsgeneration

What happened?

Description

opentelemetry-collector-contrib/processor/metricsgenerationprocessor/processor.go

Line 64 in 0592999

if operand2 <= 0 {

the check here means that if the second operand is 0 (even for actons like add or subtract), the affected rule is skipped (and the metric not generated)

Steps to Reproduce

1. Have a rule

  experimental_metricsgeneration/subset:
    rules:
    - name: part_b
      type: calculate
      metric1: total
      metric2: part_a
      operation: subtract

2. make sure part_a has a value of 0
3. query part_b

Expected Result

part_b has the same value as total.

Actual Result

part_b is not generated at all.

Collector version

main, 0.90.1

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• processor/metricsgeneration: @Aneurysm9

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

Thanks for filing @flyfire2002, and including references to the failing code. I was able to confirm your findings. This may have been done to protect against dividing by 0, or even creating new metrics that are just identical to existing, but I think the better functionality is to properly handle dividing by 0 (which is already done) and still create metrics even if they match existing values.

@Aneurysm9 may be able to share if there's something else we're missing here though. One thing also to be aware of is this component is still in Development stability. so there may be more issues like this.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/metricsgeneration: @Aneurysm9

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/metricsgeneration: @Aneurysm9

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/metricsgeneration: @Aneurysm9

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.