Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/k8sobserver] discover endpoints for sidecar-type initcontainers #29713

Closed
jinja2 opened this issue Dec 8, 2023 · 3 comments
Closed

Comments

@jinja2
Copy link
Contributor

jinja2 commented Dec 8, 2023

Component(s)

extension/observer/k8sobserver

Is your feature request related to a problem? Please describe.

Running initContainer as sidecars is beta in k8s v1.29. These sidecar containers (initContainers with restartPolicy = Always) can expose ports, receive traffic, etc. similar to the main containers in pod and run for the entirety of pod's lifecycle. I think it makes sense to update the k8sobserver to discover endpoints exposed by sidecar containers.

Describe the solution you'd like

The discovery mechanism in k8sobserver should iterate over initContainers and add any endpoints exposed by sidecar-type initContainers.

Describe alternatives you've considered

No response

Additional context

No response

@jinja2 jinja2 added enhancement New feature or request needs triage New item requiring triage labels Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Apr 7, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant